-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional provider label support #277
Conversation
6897512
to
d04c1d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a functional test each for tower and containers?
I think we can just skip beaker for now since I'm not sure that labels are a thing there (and it is much less commonly used).
Also, how well are these labels recovered after a sync?
b605076
to
191c9de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more things. Can you also resolve the merge conflicts?
ebfceba
to
83185c5
Compare
* added optional label support * provider/container - support labels, skip envars as labels * label formatting logic moved to commands.py * labels arg renamed to provider-labels * labels - AT provider - fix label value parsing * add provider_label support to execute command * fix provider_labels parsing for container provider * provider_labels are nested for AT provider * append label asserts to test_container_e2e * Add parsing of eventual settings.provider_labels for AT, Container providers * add e2e provider_labels fn test for AA
Extend broker's AnsibleTower and Container provider functionality to pass labels to be set to the spawned resources.
It accepts a string of comma-separated label values.
Broker then uses awxkit session to resolve their id's (required for the job
/launch
payload) and eventually creates the non-existing labels.User is required to have granted permissions for creating new labels (if that's even a thing) on AAP.
Plan is to implement the labeling functionality to all providers that have support of labels, e.g.
https://docs.docker.com/config/labels-custom-metadata/
example usage:
translates to:
(AAP labels are single string items)
translates to: